Forum: DarkAges BBS

src/sbbs3/main.cpp

From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Tue Sep 19 23:37:16 2023

https://gitlab.synchro.net/main/sbbs/-/commit/e5f64faf337040f12844c4cc
Modified Files:
src/sbbs3/main.cpp
Log Message:
Log a critical error message if a node is WFC, but its socket is still in use

This should avoid/work-around issue #630

Nelgin's terminal server log indicated that the node's configuration was being reloaded for a new client connection (which doesn't normally/always happen, only when there's been a config file change or a node "rerun" requested),
while there was still a user online using that node. This would explain the segfault (configuration fields being freed and reallocated).

The node_socket[] array indicates when a node thread is actively servicing
a client, so it should contain INVALID_SOCKET for the any node's that WFC.
If it doesn't, that means something/someone changed the node's status value
to 0 (WFC) in the node.dab file while the node was still in-use. Let's not crash in this case and rather just log the message and give the client the
next available node (if any).
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Sun Sep 24 06:32:43 2023

https://gitlab.synchro.net/main/sbbs/-/commit/229cca918d31e14add4b2ef7
Modified Files:
src/sbbs3/main.cpp
Log Message:
Close node socket after waiting one hour to go inactive to run exclusive event

After 90 minutes of waiting, we'll do the same abort wait (and run the event anyway), but closing the node's socket should be enough to get the node_thread to terminate and set the node status back to NODE_WFC.

Apparently some sysops like to leave their terminals idling (e.g. running MRC) and never disconnect and since they're T-exempt, the BBS won't limit their
time online to allow events to run. Exclusive events will wait for all nodes
to become inactive, but give up after 90 minutes of waiting and run the event anyway and set node status to WFC at the end. If the node was actually still connected/in-use, this could lead to the (new) critical error messages logged "!Node X status is WFC, but the node socket (N) and thread are still in use!" and other chaos (NODE STATUS FIXUP and the like).

This should prevent all that by just abruptly disconnecting the node after waiting 60 minutes for the sysop to gracefully disconnect. The log message
when this happens:
"!TIRED of waiting for node N to become inactive (status=X), closing socket Y" ---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Mon Sep 25 23:07:33 2023

https://gitlab.synchro.net/main/sbbs/-/commit/6b49ddffc9b3ee4bb3bdb3c1
Modified Files:
src/sbbs3/main.cpp
Log Message:
Auto-recycle the term server if/when the ctrl/text.ini file is created/touched ---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Nov 11 19:07:10 2023

https://gitlab.synchro.net/main/sbbs/-/commit/230bd5872d55cb239b03aeed
Modified Files:
src/sbbs3/main.cpp
Log Message:
js_init() now logs notice-level messages upon runtime or context creation fail

js_init() failures are now logged with a critical error level (instead of just "error").
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Deuc¿@VERT to Git commit to main/sbbs/master on Fri Dec 29 16:17:20 2023

https://gitlab.synchro.net/main/sbbs/-/commit/1994a535b8c0e688e8a139fc
Modified Files:
src/sbbs3/main.cpp
Log Message:
Don't log error on final channel message
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Jan 5 01:19:36 2024

https://gitlab.synchro.net/main/sbbs/-/commit/7df6956da2b4246a9ca3940e
Modified Files:
src/sbbs3/main.cpp
Log Message:
Don't log an error if there's QWKnet sub pointer value to be read

This partially reverts commit 44c3350f where a bunch of read() and write() return value checking was added.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Thu Jan 11 06:33:48 2024

https://gitlab.synchro.net/main/sbbs/-/commit/bac2285755b0eda8a209e365
Modified Files:
src/sbbs3/main.cpp
Log Message:
Another fix for the read() reutrn value FORTIFY warning

that doesn't log an error
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wed Jan 17 19:31:24 2024

https://gitlab.synchro.net/main/sbbs/-/commit/a8374b52cbc57902bb303d7e
Modified Files:
src/sbbs3/main.cpp
Log Message:
second part of commit 0b1b1a6f
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Jan 21 02:25:21 2024

https://gitlab.synchro.net/main/sbbs/-/commit/e53f173153fdaf0341cca95c
Modified Files:
src/sbbs3/main.cpp
Log Message:
Remove unnecessary call to DuplicateHandle() in Win32 builds of sbbs_t::init()

The client_socket_dup is overwritten after with the return value of accept(), so this was likely a socket/handle leak (since commit 74470573, 17 years ago).

Noticed this only after logging a new error in an SSH connection when this
call to DuplicateHandle() failed for some reason (WinError 6), but it seems like it's been redundant code for a long time now. So just ace it and possibly fix a resource leak.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Jan 22 23:43:44 2024

https://gitlab.synchro.net/main/sbbs/-/commit/346a2d304c7d921d656489ad
Modified Files:
src/sbbs3/main.cpp
Log Message:
Log the socket descriptor and protocol when getsockname() fails

This is a new error that just started cropping up. I suspect it's related to recent SSH changes. This might help a little with context, when it happens again.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Feb 6 18:35:50 2024

https://gitlab.synchro.net/main/sbbs/-/commit/af7852df11093dc6ed559f64
Modified Files:
src/sbbs3/main.cpp
Log Message:
Ignore remove() return value purposefully in this case.

Does this resolve Coverity warning? I don't rember.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Deuc¿@VERT to Git commit to main/sbbs/master on Wed Feb 7 18:23:42 2024

https://gitlab.synchro.net/main/sbbs/-/commit/2b2d8289b92d7f6e6faa1633
Modified Files:
src/sbbs3/main.cpp
Log Message:
More time_t printf fun.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wed Feb 14 21:11:56 2024

https://gitlab.synchro.net/main/sbbs/-/commit/1e734d10425f7ca7fb239931
Modified Files:
src/sbbs3/main.cpp
Log Message:
Remove line that was commented-out 14 years ago

Commit d1182efc
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Feb 24 20:54:24 2024

https://gitlab.synchro.net/main/sbbs/-/commit/0a6c1f00de9e4457f598b4f4
Modified Files:
src/sbbs3/main.cpp
Log Message:
Log a warning if failed to write to spy ring buffer
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sun Feb 25 02:31:04 2024

https://gitlab.synchro.net/main/sbbs/-/commit/4fa2aa66fda6be0ef693f512
Modified Files:
src/sbbs3/main.cpp
Log Message:
Don't log an error if spy socket write return EPIPE (expected)

Also, resove a new gcc warning about signed/unsigned compares.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Feb 27 04:41:59 2024

https://gitlab.synchro.net/main/sbbs/-/commit/a474017fb7c51f91ef9c4095
Modified Files:
src/sbbs3/main.cpp
Log Message:
sbbs_t::incom() should return NOINP immediately if/when socket disconnected

JS console.inkey() and friends use this as the underlying function to get
input from the TCP socket.

This might address issue #725

Hoping Nelgin will let us know.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Deuc¿@VERT to Git commit to main/sbbs/master on Wed Feb 28 02:20:48 2024

https://gitlab.synchro.net/main/sbbs/-/commit/4c893720f8e0c57753b08a91
Modified Files:
src/sbbs3/main.cpp
Log Message:
Attempt to fix error nelgin reported with ssh session timeouts
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Deuc¿@VERT to Git commit to main/sbbs/master on Wed Feb 28 21:29:55 2024

https://gitlab.synchro.net/main/sbbs/-/commit/e4adbcb541c6f7139e63d2ca
Modified Files:
src/sbbs3/main.cpp
Log Message:
Prevent the input thread from closing channel that has a session,
but does not yet have a session type.

Also, fix what appears to be a fairly blatant memory leak.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Deuc�@VERT to Git commit to main/sbbs/master on Thu Feb 29 17:55:23 2024

https://gitlab.synchro.net/main/sbbs/-/commit/346849ac253a08374b9bfca0
Modified Files:
src/sbbs3/main.cpp
Log Message:
Unlock ssh_mutex before calling sftps_recv()

This should fix the sftp hangs...
While FreeBSD will return EDEADLOCK when a mutex would deadlock,
Linux will do what I ask and deadlock.

Since we're not checking the return value of pthread_mutex_lock(),
this would go completely unnoticed on FreeBSD, resulting in the
mutex being unlocked early and all sorts of unprotected accesses
would happen, potentially doing crazy things. On Linux it just
deadlocks, and taking a peek at the thread backtraces makes the
problem obvious.

So, point to Linux for making life more correct for people who
do incorrect things (locking without checking the return value).

I'd also like to thank nelgin, for sticking with me on this issue
and being my gdb puppet.

And really, this commit should be shared by all the contributors
who... ��
---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

From Deuc¿@VERT to Git commit to main/sbbs/master on Fri Mar 22 04:34:07 2024

https://gitlab.synchro.net/main/sbbs/-/commit/c846776318dc4ca28946083c
Modified Files:
src/sbbs3/main.cpp
Log Message:
Break stuff to test things.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Deuc¿@VERT to Git commit to main/sbbs/master on Fri Mar 22 04:38:26 2024

https://gitlab.synchro.net/main/sbbs/-/commit/eddcfe2f9b10d250d16a6c7f
Modified Files:
src/sbbs3/main.cpp
Log Message:
Now unbreak!
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Mar 23 02:28:05 2024

https://gitlab.synchro.net/main/sbbs/-/commit/be8603b11bd6cf12c6f74256
Modified Files:
src/sbbs3/main.cpp
Log Message:
Replace (and auto-upgrade) ctrl/time.dab with time.ini

This will allow us to change scfg_t.event[].last to a time_t value (from time32_t) whenever we abandon Borland C/C++ in the future.

Now it's trival for sysops to view/edit when their timed events 'last run' values. And there's no more endianness concerns. Bad .dab files, bad, go away.

After I wrote this change, I found the original conversion code in v4upgrade.c which is almost exactly the same (except I was going to write to different filename). Finally actually implemented this. Next up: qnet.dab
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Mar 23 02:28:05 2024

https://gitlab.synchro.net/main/sbbs/-/commit/03be991a6f30b98ae9c0320b
Modified Files:
src/sbbs3/main.cpp
Log Message:
Convert (and auto-upgrade) ctrl/qnet.dab to ctrl/time.ini as well

I suppose this should've been part of the previous commit.

Again, this is almost verbatim what v4upgrade.c did (though never actually used).
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sat Mar 23 03:50:36 2024

https://gitlab.synchro.net/main/sbbs/-/commit/19ab720de38838ae2e4e1154
Modified Files:
src/sbbs3/main.cpp
Log Message:
Resolve recently introduced warnings about const char* to char* conversion

C++ <sigh>

We don't need a .ini section separator anyway.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Apr 8 21:32:54 2024

https://gitlab.synchro.net/main/sbbs/-/commit/00a80d45d884c9ab547fef31
Modified Files:
src/sbbs3/main.cpp
Log Message:
exec/*.bin cmd shell filenames were case sensitive (must've been lowercase)

... while the mods/*.bin command shell filenames could be any-case!

Only impacted non-Windows systems (UNIX file systems are case-sensitive).

Discovered while making this tutorial video: https://youtu.be/HlwQ0uX4S04
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Thu Apr 11 04:07:19 2024

https://gitlab.synchro.net/main/sbbs/-/commit/76b5c7f4399c7774c368c754
Modified Files:
src/sbbs3/main.cpp
Log Message:
Resolve CID 492287 - we don't care about the fexistcase() return value here

We're just using it to "fix" the case, if the file indeed exists.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Jul 12 00:17:01 2024

https://gitlab.synchro.net/main/sbbs/-/commit/6713d10cb1f9e44d1cb8a9e6
Modified Files:
src/sbbs3/main.cpp
Log Message:
Fix incorrect 'socket' value for new (highwater) log message
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Jul 12 00:17:01 2024

https://gitlab.synchro.net/main/sbbs/-/commit/06f6b07ddbc0ba9f7d66f5c5
Modified Files:
src/sbbs3/main.cpp
Log Message:
Eliminate large-scoped 'i' variable in bbs_thread()

This is just a code quality (readability) improvement. No functional change. ---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Jul 12 00:29:21 2024

https://gitlab.synchro.net/main/sbbs/-/commit/59e30dda6bb683b9c1a97298
Modified Files:
src/sbbs3/main.cpp
Log Message:
Fix *nix build

We removed the large-scope 'i', but didn't update the Unix-only blocks of code (dealing with UNIX domain spy sockets).
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Jul 12 00:39:16 2024

https://gitlab.synchro.net/main/sbbs/-/commit/bca9510b25f790f84f59545a
Modified Files:
src/sbbs3/main.cpp
Log Message:
Include current node number intead of socket descriptor in highwater log msg

looks better, more consistent with the log messages before/after it.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Aug 4 00:58:06 2024

https://gitlab.synchro.net/main/sbbs/-/commit/c03ed4b9ce042d5651575e18
Modified Files:
src/sbbs3/main.cpp
Log Message:
Log a warning if any socket inactivity max durations are shorter/equal to ...

to the getkey inactivity timeout.

By setting a socket timeout shorter or equal to the getkey timeout, the getkey timeout effectively does nothing.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sun Oct 13 18:36:54 2024

https://gitlab.synchro.net/main/sbbs/-/commit/2ce9ccfe50ab05c3bacf2e8d
Modified Files:
src/sbbs3/main.cpp
Log Message:
Reset sbbs_t menu path vars (menu_dir and menu_file) before execing cmd shell

I obvserved an issue with Amessyroom's bbs where his custom (JS) shell is setting bbs.menu_dir but when switching to another stock shell, his menu
files were still being displayed (with mismatching command keys as a result).

bbs.menu_dir (and implicitly, the set_menu_dir Baja function) apparently have not been used in this way (much) before.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wed Nov 13 02:08:02 2024

https://gitlab.synchro.net/main/sbbs/-/commit/ccab84c359406ffea9695db3
Modified Files:
src/sbbs3/main.cpp
Log Message:
Use new FILE_RETRY_ERRNO() macro for sopen() retries in sbbs_t::nopen()
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Nov 15 02:07:31 2024

https://gitlab.synchro.net/main/sbbs/-/commit/27e30f1277531509630d3ca8
Modified Files:
src/sbbs3/main.cpp
Log Message:
Better support for multiple hosts handling QWK events

First, fix the logged username bug in the "Lock exists" log message.
Next, double check that the trigger file (sem file or REP file) still exists after acquiring the file mutex.

Use a temp varible (fname) to make the code easier to read.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Nov 15 02:55:21 2024

https://gitlab.synchro.net/main/sbbs/-/commit/5956805f6e2e985824a86d52
Modified Files:
src/sbbs3/main.cpp
Log Message:
Log event command-lines (repeating event code was redundant)

Only log messages about QWK mutex files existing when > 60 seconds old
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Fri Nov 15 03:09:21 2024

https://gitlab.synchro.net/main/sbbs/-/commit/3127e4f4b89c73263cadd901
Modified Files:
src/sbbs3/main.cpp
Log Message:
Detect hung event_thread and log details

Add log message when spawning background timed event
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Fri Nov 15 18:20:16 2024

https://gitlab.synchro.net/main/sbbs/-/commit/6df88451e8d9ce67c27bd4d0
Modified Files:
src/sbbs3/main.cpp
Log Message:
Use timestr() instead of ctime_r() for logging full date/times

Also when detecting a blocked event_thread, log the event_code that is/was running last.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Nov 15 18:26:02 2024

https://gitlab.synchro.net/main/sbbs/-/commit/87b22bda88174a8e03e25558
Modified Files:
src/sbbs3/main.cpp
Log Message:
Reolve !ERROR 2 (No such file or directory) removing "data/pack####.now"

glob() results might be out of date by the time we look at each file, just
skip missing QWK pack semaphore files silently. This should resolve the
".now already gone" messages too. Hopefully.

Removed some extraneous quotes around logged event command-lines.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Nov 16 00:29:09 2024

https://gitlab.synchro.net/main/sbbs/-/commit/f37e9789f42d73d4991d2ff3
Modified Files:
src/sbbs3/main.cpp
Log Message:
Use fmutex_open() instead of fmutex() to better protect the pack*.lock files ---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Nov 16 04:17:53 2024

https://gitlab.synchro.net/main/sbbs/-/commit/6dda18740c154c5f099070d1
Modified Files:
src/sbbs3/main.cpp
Log Message:
Use fmutex_close() and don't log ENOENT errors when removing pack*.now files ---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Nov 16 04:37:59 2024

https://gitlab.synchro.net/main/sbbs/-/commit/208f263b94e85ef91dc62cc3
Modified Files:
src/sbbs3/main.cpp
Log Message:
Just a little wording update on the fmutex file open log message
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sun Nov 17 09:02:57 2024

https://gitlab.synchro.net/main/sbbs/-/commit/2fa8db2b6a1a5da43db71887
Modified Files:
src/sbbs3/main.cpp
Log Message:
Perform "first level Ctrl-C input checking" even when in Telnet BINARY_TX

This condition caused aborting BBS operations via Ctrl-C to fail when connecting from a traditional Telnet client using binary transmission
mode (e.g. telnet -8) or SyncTERM v1.2rc6.

The check of rio_abortable was probably enough to disable this function
during file transfers (e.g. we've had no issues with SSH file transfers
that might include byte 0x03 received from the client), but I added the
check for SS_FILEXFER system status check too, perhaps unnecessary.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Nov 19 04:11:42 2024

https://gitlab.synchro.net/main/sbbs/-/commit/6d7f85680177ba6fef1946f2
Modified Files:
src/sbbs3/main.cpp
Log Message:
Don't use uninitialized variable: lockfname

Where's the compiler warnings guys?
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Wed Nov 20 04:55:43 2024

https://gitlab.synchro.net/main/sbbs/-/commit/fa5321fe8850f6d2d9558312
Modified Files:
src/sbbs3/main.cpp
Log Message:
request_telnet_opt() will ignore all cmds but DO, DONT, WILL and WONT

This allows us to save unitialized telnet_*_option values (i.e. 0x00) and pass those values back to request_telnet_opt() with no side effect.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat Nov 23 07:24:28 2024

https://gitlab.synchro.net/main/sbbs/-/commit/277855436d2143b88bd9a501
Modified Files:
src/sbbs3/main.cpp
Log Message:
Fix crash when NO_EVENTS option is set for terminal server

Don't deref that null pointer
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Deuc¿@VERT to Git commit to main/sbbs/master on Sun Nov 24 15:34:14 2024

https://gitlab.synchro.net/main/sbbs/-/commit/26886a8c7ba879f2e84d2650
Modified Files:
src/sbbs3/main.cpp
Log Message:
Remove ssh_errors variable.

We're carefully counting the errors, but never looking at the count.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on macOS)@VERT to Git commit to main/sbbs/master on Mon Dec 2 01:57:53 2024

https://gitlab.synchro.net/main/sbbs/-/commit/89a884e9dca8116090df2d87
Modified Files:
src/sbbs3/main.cpp
Log Message:
Log the error description upon failure to send on socket
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Dec 6 23:38:28 2024

https://gitlab.synchro.net/main/sbbs/-/commit/f83b805f2ebdc68d7612ab6d
Modified Files:
src/sbbs3/main.cpp
Log Message:
Don't try to renaming a bad (unpackable) REP packet if it doesn't exist

There still appears to be some race condition with network (Samba) FS
directory caching and opening/locking of files, so it does seem illogical that the packet file wouldn't exist at this point (since we have the lock file opened) but this does still happen on occasion on Vertrauen.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Dec 14 19:08:11 2024

https://gitlab.synchro.net/main/sbbs/-/commit/65ff68a0bb3386cd6d4c3fab
Modified Files:
src/sbbs3/main.cpp
Log Message:
Always unlock nodefile_mutex before calling errormsg()
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sun Dec 22 20:37:37 2024

https://gitlab.synchro.net/main/sbbs/-/commit/74724d0b83150c1da1a88d74
Modified Files:
src/sbbs3/main.cpp
Log Message:
When searching for unused nodes, skip nodes that have sockets in-use

We already know such nodes are in-use, so no need to read their node.dab
record and put extra contention on the node.dab file. Hoepfully this
reduces or eliminates occurrences of the error:
Node n status is WFC, but the node socket (s) and thread are still in use! Though I kind of expect occurrences of "NODE STATUS FIXUP" errors to likely return.

We could in theory just track status of nodes in memory (for those
nodes that this instance of sbbs controls), and not read the node.dab file at all when checking those nodes' status, but:
- that would prevent out of process control of node status
e.g. using the node utility to mark a node as offline
- we'd have to protect instance of in-memory node status checking/changing
with a mutex
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Mon Dec 23 03:32:50 2024

https://gitlab.synchro.net/main/sbbs/-/commit/a4f032b82ed2ddfbd23e963d
Modified Files:
src/sbbs3/main.cpp
Log Message:
Fix-up node status when node status is in-use, but no socket active

This is a situation we can auto-correct and log a message when we do.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Dec 27 22:17:12 2024

https://gitlab.synchro.net/main/sbbs/-/commit/2d487931e40d312071024416
Modified Files:
src/sbbs3/main.cpp
Log Message:
Fix race conditions around node_socket and node.dab checks

Check and clear/invalidate node_socket while holding the node.dab record
lock.

This should fix the error reported by kk4qnb (KK4QBN)
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Jan 2 03:40:30 2025

https://gitlab.synchro.net/main/sbbs/-/commit/480598355c061c7a3507f24e
Modified Files:
src/sbbs3/main.cpp
Log Message:
Continue the "ERROR ... renaming" bad QWK packet fight

Check and log the length of the packet now (since fexist() continues to report that the file exists when fexistcase() said it did not, even when
experimenting with adding a call to access(filanem, F_OK).

This likely affects no system but VERT.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Jan 2 06:34:57 2025

https://gitlab.synchro.net/main/sbbs/-/commit/e4e41db746c18c1bab6a0083
Modified Files:
src/sbbs3/main.cpp
Log Message:
Don't create (or write) to qnet.dab, so open with right access

We're just converting/upgrading this file (to time.ini), so don't log an error (reading) if/when the file doesn't exist.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Jan 3 23:45:26 2025

https://gitlab.synchro.net/main/sbbs/-/commit/d06e2f27e7f3862cf049bc6a
Modified Files:
src/sbbs3/main.cpp
Log Message:
Add another flength() check before renaming bad QWK packets

To hopefully address:
!ERROR 2 (No such file or directory) renaming s:\sbbs\data\file/somenum.rep
(-1 bytes) to s:\sbbs\data\file/somenum.rep.6777ed7c.bad

Clearly flength() is returning -1 (file doesn't exist) at this point, so perhaps the call to fremove() just above updated a cached directory?
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Jan 21 02:37:00 2025

https://gitlab.synchro.net/main/sbbs/-/commit/3bf096b52465792776df3787
Modified Files:
src/sbbs3/main.cpp
Log Message:
Make JS global alert() and deny() methods inline with jsexec versions

alert() doesn't throw exception on null/undefined, just no arg

deny() throws exception on no args or null/undefined arg
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sun Feb 9 06:09:25 2025

https://gitlab.synchro.net/main/sbbs/-/commit/64352121b6727a90eee5e848
Modified Files:
src/sbbs3/main.cpp
Log Message:
Don't attempt to remove inbound QWK packet if doesn't exist (renamed?)

Address error report by Greg Meckel (THEICECA)
evnt QNET !ERROR 2 (No such file or directory) (EinError 2) in main.cpp line 3195 (event_thread) removing "C:\sbbs\data\VERT.qwk" access=0

... this could happen after a bad QWK packet was detected and renamed.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Sun Mar 23 23:11:53 2025

https://gitlab.synchro.net/main/sbbs/-/commit/6a0971f6e79ec18c2ed611dc
Modified Files:
src/sbbs3/main.cpp
Log Message:
filelength() can return -1 on error, deal

Just caught during code review
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Sun Mar 23 23:11:54 2025

https://gitlab.synchro.net/main/sbbs/-/commit/0ac5ed5728c53d93eb347c23
Modified Files:
src/sbbs3/main.cpp
Log Message:
Set node "interrupt" flag to try to gracefully disconnect user blocking event

When a timed event is configured to run "exclusively", all nodes need to not be in in-use. As it was, after waiting 60 minutes for the online user(s) to
notice they'd run out of time and disconnect, we'd just (rather ungracefully) close the sockets used by such node(s) connections. This results in same logged errors about trying to send to bad socket descriptors and provides no feedback to the user about why they were disconnected.

Since we have the node interrupt flag (which hopefully, all scripts are checking via node_sync) - use that to try to more gracefully terminate the user's session/connection after 30 minutes of waiting for the user to disconnect.

If after 60 minutes of waiting, the node is still in-use, we still do the socket disconnection method.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Deuc¿@VERT to Git commit to main/sbbs/master on Thu Apr 10 19:57:08 2025

https://gitlab.synchro.net/main/sbbs/-/commit/aea882a8e4552b64c03c521d
Modified Files:
src/sbbs3/main.cpp
Log Message:
Initialize Terminal in global sbbs when answering

Should fix issue where extra pauses occur on connection.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Deuc¿@VERT to Git commit to main/sbbs/master on Thu Apr 10 19:58:17 2025

https://gitlab.synchro.net/main/sbbs/-/commit/f218ad1fec992a71f590120e
Modified Files:
src/sbbs3/main.cpp
Log Message:
Fix typo (thrad->thread)
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wed Dec 31 01:48:10 2025

https://gitlab.synchro.net/main/sbbs/-/commit/70480dcee4378c21be0ca536
Modified Files:
src/sbbs3/main.cpp
Log Message:
Add some passthru thread debug log messages

To hopefully help identify the cause of issue #1038

The theory being that the client socket was disconnected while running an external program (sexyz in this case) and this check at the end of external() (the *nix version) might have a race condition with the passthru thread terminating due to disconnection as well:
if (!(mode & EX_STDIN)) {
if (passthru_thread_running)
passthru_socket_activate(false);
else
pthread_mutex_unlock(&input_thread_mutex);
}
in which case it would try to unlock the input_thread_mutex that it did not own. I'm not clear why that would cause the pthread_mutex_destroy() call to fail (on input_thread_mutex) but maybe it does.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Jan 1 22:32:06 2026

https://gitlab.synchro.net/main/sbbs/-/commit/7e7db957384647c44958d0cb
Modified Files:
src/sbbs3/main.cpp
Log Message:
When upgrading a legacy time.dab to new time.ini format, ignore unreadables

It's possible the configuration was upgraded (e.g. by update.js) before any timed events have run, so the time.dab could be short. Just zero-initialize (and don't log any errors) if there's trouble reading a legacy timestamp from time.dab or qnet.dab.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Jan 11 03:40:05 2026

https://gitlab.synchro.net/main/sbbs/-/commit/f21adb001964358bc95c1e28
Modified Files:
src/sbbs3/main.cpp
Log Message:
Defeat the extra lines goings to the events.log file

Example:
2026-01-06 23:59:59 BBS Events New Day - Prev: Wed Jan 07 2026 12:00 am
!= New Day - Prev: Wed Jan 07 2026 12:00 am

In theory this cold happen while a user was logging on, hence the use of llprintf()->logline(), but we don't want that redundant noise in the
events.log file so we have to play a dance with 'online' value.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Jan 20 21:00:06 2026

https://gitlab.synchro.net/main/sbbs/-/commit/7e8760ce6ef8c60051202ef0
Modified Files:
src/sbbs3/main.cpp
Log Message:
Don't backup empty user bases or mail bases

Address "it seems silly to have five backup empty mail files too" comment
in issue #993.
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Jan 20 21:00:06 2026

https://gitlab.synchro.net/main/sbbs/-/commit/f66c37792f6027f1b1cdd06f
Modified Files:
src/sbbs3/main.cpp
Log Message:
Log the number of users and mail messages that were included in the backups
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Jan 20 21:00:06 2026

https://gitlab.synchro.net/main/sbbs/-/commit/6f4dac2d037978d0c92dfa7f
Modified Files:
src/sbbs3/main.cpp
Log Message:
Remove hyphen from "Backing-up" and "Backed-up" log messages
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Tue Jan 20 22:53:22 2026

https://gitlab.synchro.net/main/sbbs/-/commit/674c4facfbfcd5855915ade5
Modified Files:
src/sbbs3/main.cpp
Log Message:
Fix (new) bug caught by GCC printf verifier
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Jan 27 11:30:04 2026

https://gitlab.synchro.net/main/sbbs/-/commit/372404c4f6491a962cbd9471
Modified Files:
src/sbbs3/main.cpp
Log Message:
Don't try to validate the userbase if it doesn't exist

Fix for new installs as reported by Storm on IRC (thank you)
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

Who's Online
Recent Visitors
- Zengarden
  Wed Feb 11 17:39:27 2026
  from Bowling Green, Ky via Telnet
- Ilop
  Sat Jan 31 03:58:07 2026
  from Canada via Telnet
- A L L E O N
  Fri Jan 16 23:33:08 2026
  from Loveland, Colorado via Telnet
- Mr Chats
  Sat Dec 27 20:46:15 2025
  from Florence, Alabama via Telnet

System Info

Sysop:	Gargoyle
Location:	Wayne, OK
Users:	22
Nodes:	10 (0 / 10)
Uptime:	85:30:47
Calls:	147
Calls today:	1
Files:	295
Messages:	66,704

src/sbbs3/main.cpp

Who's Online

Recent Visitors

System Info